Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression on filters using dot separator in source #4545

Merged
merged 6 commits into from
Mar 19, 2020
Merged

Fix regression on filters using dot separator in source #4545

merged 6 commits into from
Mar 19, 2020
+40 −17

Conversation

JulienMattiussi
Copy link
Contributor

@JulienMattiussi JulienMattiussi commented Mar 17, 2020 •
edited
Loading

Closes #4539

Issue

When we add a composed filter (source='parent.child') with no default value, it is not displayed.

Solution

Fix displayedFilter object.

@JulienMattiussi JulienMattiussi added the WIP Work In Progress label Mar 17, 2020
@JulienMattiussi JulienMattiussi added RFR Ready For Review and removed WIP Work In Progress labels Mar 19, 2020
@fzaninotto fzaninotto changed the title Fix composed filters Fix regression on filters using dot separator in source Mar 19, 2020
@fzaninotto fzaninotto merged commit ecd05d9 into master Mar 19, 2020
@fzaninotto fzaninotto deleted the fix-composed-filters branch March 19, 2020 15:01
@fzaninotto fzaninotto added this to the 3.3.2 milestone Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
3.3.2
Development

Successfully merging this pull request may close these issues.

Filter not displayed with a compound source
2 participants
@JulienMattiussi @fzaninotto